This is a bit tricky as I treat most of my professions as set it and forget it, I usually don’t pay much attention once I have it figured out and TradeSkillMaster is running the show. There’s basically only four markets I’m in right now, and have been in fairly consistently over my gold making career:
Of those, it’s a bit of a toss up between Inscription and Jewelcrafting. Jewelcrafting has been sort of my ol’ faithful, it’s usually always viable, maybe not printing gold profitable, but still viable. Jewelcrafting, as I discussed previously, has been the profession I’ve been using the longest, it was the first profession I ever used in gold making.
Inscription has been a lot less reliable though. While it started off strong for me in Wrath of the Lich King, it brought in considerably less profits in Cataclysm and Mists of Pandaria. To top it off, I completely missed Glyphmas, which had gold makers at the time up to their eyebrows in gold.
So what do I think my greatest gold making profession is? I’d have to say Jewelcrafting.